[PATCH] D128317: stop llvm-reduce from introducing undefs

[John Regehr via Phabricator via llvm-commits]

regehr added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/Utils.cpp:19
+Value* llvm::getDefaultValue(Type *T) {
+  return T->isVoidTy() ? UndefValue::get(T) : Constant::getNullValue(T);
+}
----------------
aeubanks wrote:
> aeubanks wrote:
> > `PoisonValue`?
> looking at `Constant::getNullValue`, looks like labels also don't have a null value, but I guess we're not using this with labels
my take is it's not worth putting an assert on this since if a label goes into Constant::getNullValue() it'll hit the llvm_unreachable there, which is about as useful as hitting an assert


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128317/new/

https://reviews.llvm.org/D128317