[PATCH] D128317: stop llvm-reduce from introducing undefs

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 14:46:17 PDT 2022


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

makes sense to me



================
Comment at: llvm/tools/llvm-reduce/deltas/Utils.cpp:19
+Value* llvm::getDefaultValue(Type *T) {
+  return T->isVoidTy() ? UndefValue::get(T) : Constant::getNullValue(T);
+}
----------------
`PoisonValue`?


================
Comment at: llvm/tools/llvm-reduce/deltas/Utils.cpp:19
+Value* llvm::getDefaultValue(Type *T) {
+  return T->isVoidTy() ? UndefValue::get(T) : Constant::getNullValue(T);
+}
----------------
aeubanks wrote:
> `PoisonValue`?
looking at `Constant::getNullValue`, looks like labels also don't have a null value, but I guess we're not using this with labels


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128317/new/

https://reviews.llvm.org/D128317



More information about the llvm-commits mailing list