[PATCH] D127777: [ThinLTO][ELF] Add --thinlto-emit-index-files option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: lld/test/ELF/lto/thinlto-emit-index.ll:7
+; RUN: rm -rf %t.dir && mkdir %t.dir && cd %t.dir
+; RUN: llvm-as %s -o %t1.o
+; RUN: llvm-as %p/Inputs/thinlto.ll -o %t2.o
----------------
Since you have used `cd`, you don't need `%t` in the output filenames (`%t1.o`). You may just use `1.o`.

I just updated `thinlto-index-only.ll`


================
Comment at: lld/test/ELF/lto/thinlto-emit-index.ll:54
+; RUN: not ld.lld --thinlto-emit-index-files -shared %t2.o --start-lib %t1.o --end-lib \
+; RUN: --thinlto-prefix-replace="abc;xyz" 2>&1 | FileCheck %s --check-prefix=ERR2
+; ERR2: --thinlto-prefix-replace is not supported with --thinlto-emit-index-files
----------------
`thinlto-prefix-replace` has been tested. Don't repeat the test here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127777/new/

https://reviews.llvm.org/D127777