[PATCH] D127777: [ThinLTO][ELF] Add --thinlto-emit-index-files option

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 12:14:21 PDT 2022


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with one comment fix suggestion. Wait to see if @MaskRay has any additional comments.



================
Comment at: lld/test/ELF/lto/thinlto-emit-index.ll:37
+;; Test that LLD generates an empty index even for lazy object file that is not added to link.
+;; Test LLD generates empty imports file too because of thinlto-emit-imports-files option.
+; RUN: rm -f %t1.o.thinlto.bc %t1.o.imports
----------------
Suggest: "Test that LLD also generates empty imports file with the --thinlto-emit-imports-files option."  (I realize the original comment was cloned from the other test, but let's go ahead and improve it here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127777/new/

https://reviews.llvm.org/D127777



More information about the llvm-commits mailing list