[PATCH] D128154: [BOLT][NFC] Use range-based STL wrappers

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 18:08:51 PDT 2022


Amir added a comment.

In D128154#3600489 <https://reviews.llvm.org/D128154#3600489>, @rafauler wrote:

> It's a bit confusing to call a function named "stable_sort", which is a well-known C++ stdlib function, but we're actually calling stable_sort from LLVM and not from stdlib. I've tried looking up in LLVM repo and there are all sorts of usages of is_contained, for example: some of them use llvm:is_contained, others use is_contained directly. What is your take on this? Should we call llvm::stable_sort, or just stable_sort?

I’ll make it fully qualified to avoid ambiguity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128154/new/

https://reviews.llvm.org/D128154



More information about the llvm-commits mailing list