[PATCH] D128154: [BOLT][NFC] Use range-based STL wrappers

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 16:34:22 PDT 2022


rafauler added a comment.

It's a bit confusing to call a function named "stable_sort", which is a well-known C++ stdlib function, but we're actually calling stable_sort from LLVM and not from stdlib. I've tried looking up in LLVM repo and there are all sorts of usages of is_contained, for example: some of them use llvm:is_contained, others use is_contained directly. What is your take on this? Should we call llvm::stable_sort, or just stable_sort?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128154/new/

https://reviews.llvm.org/D128154



More information about the llvm-commits mailing list