[PATCH] D127729: [Bitcode] Support expanding constant expressions into instructions

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 08:33:26 PDT 2022


nikic updated this revision to Diff 438414.
nikic edited the summary of this revision.
nikic added reviewers: aeubanks, dexonsmith.
nikic added a comment.

Okay, the metadata use-list order issue is fixed now as well, so this patch should be ready. The extra subtlety there is that function metadata is decoded in one go before the function instructions, rather than interleaved as it gets used. Additionally it's necessary to explicitly visit these operands in predictValueUseListOrder(), otherwise we might not emit a uselistorder directive at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127729/new/

https://reviews.llvm.org/D127729

Files:
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Reader/ValueList.cpp
  llvm/lib/Bitcode/Reader/ValueList.h
  llvm/lib/Bitcode/Writer/ValueEnumerator.cpp
  llvm/test/Bitcode/constexpr-to-instr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127729.438414.patch
Type: text/x-patch
Size: 91321 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220620/449560ff/attachment.bin>


More information about the llvm-commits mailing list