[PATCH] D127729: [Bitcode] Support expanding constant expressions into instructions

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 07:08:36 PDT 2022


nikic updated this revision to Diff 438380.
nikic added a comment.

> I’m curious: is the metadata loader issue related to use-list order, or independent?

Both :) I just fixed the general issue, and am now left with the use-list order issue only. I think we should be ordering MetadataAsValue uses as part of functions now (rather than globally) and also predict use lists for them, but I haven't figured out the details yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127729/new/

https://reviews.llvm.org/D127729

Files:
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Reader/ValueList.cpp
  llvm/lib/Bitcode/Reader/ValueList.h
  llvm/lib/Bitcode/Writer/ValueEnumerator.cpp
  llvm/test/Bitcode/constexpr-to-instr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127729.438380.patch
Type: text/x-patch
Size: 88793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220620/45220462/attachment-0001.bin>


More information about the llvm-commits mailing list