[PATCH] D127948: [TableGen] Add new operator !instanceof

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 05:05:30 PDT 2022


nhaehnle added a comment.

Hmm, I now saw the earlier discussion and @tra's very good points in it. If `!instanceof` accepts defs, then it becomes somewhat redundant with `!isa`, which I hadn't considered. Can you improve the error checking so that if a record is provided as an argument, the message advises that `!isa` should be used instead?

FWIW, I'm not 100% happy about the name "instanceof", but I can't think of anything better right now that isn't super verbose. And I don't want to bikeshed this change to death either :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127948/new/

https://reviews.llvm.org/D127948



More information about the llvm-commits mailing list