[PATCH] D127948: [TableGen] Add new operator !instanceof
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 20 04:58:55 PDT 2022
nhaehnle added a comment.
I think this change makes sense and it looks good to me, except for one thing: if I were to see an `!instanceof` without context, I would expect that it is also able to take a record/def as operand. That kind of use is likely to come up eventually, and people shouldn't have to artificial convert the record/def to its name first. So I'm in favor of this change, except I'd ask you to change the implementation (and tests) to support both kinds of use.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127948/new/
https://reviews.llvm.org/D127948
More information about the llvm-commits
mailing list