[PATCH] D127938: Update Windows packaging script.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:65
+
+set location=https://github.com/llvm/llvm-project/archive/refs/heads/main.zip
+
----------------
hans wrote:
> "location" isn't very descriptive, how about "source_location" or "source_url"?
Changed to "source_location".


================
Comment at: llvm/utils/release/build_llvm_release.bat:55
+REM Validate command line options.
+if not defined output (
+  echo Missing output directory.
----------------
hans wrote:
> thieta wrote:
> > CarlosAlbertoEnciso wrote:
> > > thieta wrote:
> > > > I think you can default to a output directory instead of failing.
> > > May be use the user temporal directory as default value.
> > yeah that works.
> Using the current working directory seems like the more natural choice.
Changed to use current directory as default.


================
Comment at: llvm/utils/release/build_llvm_release.bat:112
   -DCMAKE_CL_SHOWINCLUDES_PREFIX="Note: including file: " ^
-  -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;compiler-rt;lldb;openmp"
+  -DLLVM_LIT_ARGS="-s" ^
+  -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;compiler-rt;openmp;lldb"
----------------
hans wrote:
> CarlosAlbertoEnciso wrote:
> > hans wrote:
> > > What's this for?
> > The LLVM_LIT_ARGS are the arguments for the Integreted tester.
> > 
> > https://releases.llvm.org/11.0.0/docs/CommandGuide/lit.html
> > 
> > and we use '-s' to reduce the amount of information generated during testing.
> I don't think the current amount of information is too noisy.
Removed `-DLLVM_LIT_ARGS="-s"`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127938/new/

https://reviews.llvm.org/D127938