[PATCH] D127938: Update Windows packaging script.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In D127938#3595669 <https://reviews.llvm.org/D127938#3595669>, @hans wrote:

> Taking a step back, at this point the patch is almost a rewrite of the current script. It's doing a lot of different things, and I'm not sure I agree with all of them. Perhaps we need to discuss a bit more what are the goals of these changes, and whether they can be done as a series of incremental patches rather than a rewrite.

I am having the same feeling. I think most of the "new things" are useful but may be incremental pacthes. I would suggest to define what we can add on each patch.



================
Comment at: llvm/utils/release/build_llvm_release.bat:6
+REM
+REM Run the script with administrator permissions.
+if not exist %SYSTEMROOT%\SYSTEM32\WDI\LOGFILES (
----------------
hans wrote:
> CarlosAlbertoEnciso wrote:
> > thieta wrote:
> > > CarlosAlbertoEnciso wrote:
> > > > hans wrote:
> > > > > Wait, what? This seems undesirable.
> > > > Running the script from a standard DOS prompt, I get the following errors:
> > > > 
> > > > 
> > > > ```
> > > > ...
> > > > 7-Zip 21.06 (x64) : Copyright (c) 1999-2021 Igor Pavlov : 2021-11-24
> > > > 
> > > > Scanning the drive for archives:
> > > > 1 file, 223803667 bytes (214 MiB)
> > > > 
> > > > Extracting archive: src.zip
> > > > --
> > > > Path = src.zip
> > > > Type = zip
> > > > ...
> > > > ERROR: Cannot create symbolic link : A required privilege is not held by the client. : .\llvm-project-main\libclc\clspv64
> > > > ERROR: Cannot create symbolic link : A required privilege is not held by the client. : .\llvm-project-main\libcxx\test\std\pstl
> > > > ERROR: Cannot create symbolic link : A required privilege is not held by the client. : .\llvm-project-main\openmp\tools\analyzer\llvm-openmp-analyzer++
> > > > 
> > > > Sub items Errors: 17
> > > > 
> > > > Archives with Errors: 1
> > > > 
> > > > Sub items Errors: 17
> > > > ```
> > > > May be the configuration we use is incorrect.
> > > symlinks requires admin rights on windows unfortunately. But I have never seen this - so it has to be some place where it conditions the symlinking?
> > Removed the administrator check. I am assumming it is my local configuration.
> Some searching suggests this may be to due to 7zip's behaviour having changed in recent versions. I'm using 18.05 which is probably old by now, but doesn't seem to have this problem.
I am using `7-Zip 21.06 (x64)`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127938/new/

https://reviews.llvm.org/D127938