[PATCH] D125388: Allow type-mismatching RAUW of values in metadata, and add C API.

Mon Jun 20 01:54:45 PDT 2022

nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

I don't think this change makes sense on a couple of levels:

- I don't believe that `ValueAsMetadata::handleRAUW()` is intended as a public API at all.
- The original problem seems like a bug in GlobalDCE -- did anyone investigate why it happens?
- With opaque pointers the replacement doesn't use a bitcast anyway, so the issue is "fixed" as a side-effect. As this API will only go into LLVM 15, it would not be useful.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125388/new/

https://reviews.llvm.org/D125388