[PATCH] D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz accepted this revision.
sgraenitz added a comment.

LGTM. Let's go and land this once Lang's two latest comment got addressed.



================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/MemoryMapper.h:91
+  void release(std::vector<ExecutorAddr> &Reservations,
+               OnReleasedFunction OnRelease) override;
+
----------------
argentite wrote:
> sgraenitz wrote:
> > Maybe we can add a comment for implict vs. explicit deinit/release somewhere? This seems to be specific for the `InProcessMemoryMapper`. It took me a while to figure out that the destructor reimplements them (instead of calling) for the implicit case.
> The plan is to have some kind of implicit deinitialization in all MemoryMappers. The release() and deinitialize() are there for cases where we want to release early without terminating the program. Do you think anything specific that we should mention?
With the comments on `deinitialize()`/`release()` I think it's ok now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127491/new/

https://reviews.llvm.org/D127491