[PATCH] D128144: [AArch64] Known bits for AArch64ISD::DUP

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

In D128144#3594769 <https://reviews.llvm.org/D128144#3594769>, @RKSimon wrote:

> Thanks for isCanonicalConstantNode - hopefully it will work for some similar cases we have on X86.
>
> Would AArch64 benefit from overriding isSplatValueForTargetNode to handle AArch64ISD::DUP?

Yeah that might be useful - thanks for the suggestion, I'll take a look. In the long run I think I would like to remove AArch64ISD::DUP and just use ISD::SPLAT_VECTOR for all vectors across AArch64. That would take some time though, and would hit the same problem of canonicalising into a BUILD_VECTOR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128144/new/

https://reviews.llvm.org/D128144