[PATCH] D128121: [NFC][Alignment] Remove max functions between Align and MaybeAlign

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 19 22:51:00 PDT 2022


courbet added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:6251
+        Alignment = std::max(
+            Alignment, llvm::Align(AlignmentAPI.getValue().getZExtValue()));
       }
----------------
Why is this OK ? I'm seeing:

```
if (!SimpleV.hasValue())
      return APInt(64, 0);
```

in `getAPIInt`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128121/new/

https://reviews.llvm.org/D128121



More information about the llvm-commits mailing list