[PATCH] D42759: [CGP] Split large data structres to sink more GEPs

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added inline comments.
Herald added projects: LLVM, All.


================
Comment at: llvm/trunk/lib/CodeGen/CodeGenPrepare.cpp:3816
+                 TLI.shouldConsiderGEPOffsetSplit() && Depth == 0 &&
+                 ConstantOffset > 0) {
+        // Record GEPs with non-zero offsets as candidates for splitting in the
----------------
Is there any reason to not use '!=' as oppsed to '>' here (which would match the comment below)?

On SystemZ negative offsets are not supported on vector instructions.





Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42759/new/

https://reviews.llvm.org/D42759