[PATCH] D128055: [llvm-ar] Improve MRI script CREATE command handling

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Consider precommitting the tests to make the change more focused?



================
Comment at: llvm/test/tools/llvm-ar/mri-addlib.test:3
 
 # RUN: rm -rf %t && mkdir -p %t
+# RUN: split-file %s %t
----------------
`# RUN: rm -rf %t && split-file %s %t && cd %t`

split-file doesn't need mkdir.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1066
+      if (!Create)
+        fail("no open output archive");
       object::Archive &Lib = readLibrary(Rest);
----------------
output archive is not opened?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128055/new/

https://reviews.llvm.org/D128055