[PATCH] D128055: [llvm-ar] Improve MRI script CREATE command handling

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 06:53:52 PDT 2022


gbreynoo created this revision.
gbreynoo added reviewers: jhenderson, MaskRay.
Herald added subscribers: StephenFan, rupprecht.
Herald added a project: All.
gbreynoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I discovered that when compared to GNU the llvm-ar MRI script parsing of CREATE could lead to some strange behaviour. This fix improves the error message in the case when no archive name is given and will not allow the adding of members until CREATE is called. Along with this change I added more testing of the CREATE command.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128055

Files:
  llvm/test/tools/llvm-ar/mri-addlib.test
  llvm/test/tools/llvm-ar/mri-addmod.test
  llvm/test/tools/llvm-ar/mri-create.test
  llvm/tools/llvm-ar/llvm-ar.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128055.437876.patch
Type: text/x-patch
Size: 7816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220617/f9ba8211/attachment.bin>


More information about the llvm-commits mailing list