[PATCH] D128070: [Stats] Change Value type from unsigned to uint64_t.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 12:24:19 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

`[Stats] ` is an abbreviation of an uncommon tag `[Statistics] `. I'd use `[Support] Change TrackingStatistic to use uint64_t instead of unsigned`

We check 64-bit atomic support (CMake `check_working_cxx_atomics64`), so the new use is fine. It may be first time LLVMSupport uses it, though (not checked very carefully).

I'll suggest that postpone this to at least Monday afternoon (skipping weekend) to give other folks a chance to look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128070/new/

https://reviews.llvm.org/D128070



More information about the llvm-commits mailing list