[PATCH] D128070: [Stats] Change Value type from unsigned to uint64_t.

Fri Jun 17 10:12:35 PDT 2022

MaskRay added a comment.

I think this makes sense. Any chance to compare `clang` sizes with and without this change? I think it is fine to increase the size a bit as fixing the overflow problem is more important, but the number should still be useful.

================
Comment at: llvm/unittests/ADT/StatisticTest.cpp:46
 #else
-  EXPECT_EQ(Counter, 0u);
+  EXPECT_EQ(Counter, 0ull);
 #endif
----------------
`UINT64_C(0)` may be better.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128070/new/

https://reviews.llvm.org/D128070