[PATCH] D126815: [llvm] [Support] [Debuginfod] waitQueueSize for ThreadPool

Noah Shutty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 17:57:11 PDT 2022


noajshu added a comment.

In D126815#3568645 <https://reviews.llvm.org/D126815#3568645>, @mysterymath wrote:

> In D126815#3568630 <https://reviews.llvm.org/D126815#3568630>, @noajshu wrote:
>
>> I suppose another direction would be to abandon the producer-consumer model altogether. In D114845 <https://reviews.llvm.org/D114845>, this could be done (in part) by letting the threads share access to the `recursive_directory_iterator`, acquiring a lock then advancing it on their own to harvest jobs from the filesystem.
>
> I like that; it should decouple those commits from this one, and it should be quite a bit cleaner than maintaining size counters.

Sounds good, thanks! I have updated D114845 <https://reviews.llvm.org/D114845> with this change. I will wait until at least next week before merging to leave time for comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126815/new/

https://reviews.llvm.org/D126815



More information about the llvm-commits mailing list