[PATCH] D128016: Recommit "[RISCV] Enable subregister liveness tracking for RVV."

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM w/minor optional comments.



================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:206
+    return EnableSubRegLiveness;
+  // Enable subregister liveness for RVV to better handle LMUL>1 and segment
+  // load/store.
----------------
Is there an active reason not to enable sub-reg liveness unconditionally?


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:5
 ; RUN: llc -mtriple=riscv64 -mattr=+f,+m,+zfh,+experimental-zvfh < %s \
-; RUN:   -riscv-enable-subreg-liveness=true| FileCheck %s --check-prefix=SUBREGLIVENESS
+; RUN:   | FileCheck %s --check-prefix=SUBREGLIVENESS
 
----------------
Please leave it explicitly enabled since a) the test seems to care, and b) it'll reduce churn if we have to revert again.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128016/new/

https://reviews.llvm.org/D128016