[PATCH] D127915: [windows][support] Improve backtrace emitted in crash report without llvm-symbolizer

[ben via Phabricator via llvm-commits]

bd1976llvm added inline comments.


================
Comment at: llvm/lib/Support/Windows/Signals.inc:340
 
 // Print the parameters.  Assume there are four.
 #if defined(_M_X64) || defined(_M_ARM64)
----------------
rnk wrote:
> I propose we scrap this parameter printing. I've never found it useful. It's a bunch of hex noise that makes the crash report look scary. My understanding is that doesn't work well on win64, since it assumes parameters are homed into the shadow stack space, which Clang doesn't generally do.
Yes. Nice suggestion. We recently debugged out a horrible close-to-impossible-to-reproduce issue where this backtrace information was all we had available. I'll ask tomorrow whether anyone made use of these parameters and get back to you...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127915/new/

https://reviews.llvm.org/D127915