[PATCH] D127915: [windows][support] Improve backtrace emitted in crash report without llvm-symbolizer

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 16:24:29 PDT 2022


rnk added a comment.

Seems useful



================
Comment at: llvm/lib/Support/Windows/Signals.inc:340
 
 // Print the parameters.  Assume there are four.
 #if defined(_M_X64) || defined(_M_ARM64)
----------------
I propose we scrap this parameter printing. I've never found it useful. It's a bunch of hex noise that makes the crash report look scary. My understanding is that doesn't work well on win64, since it assumes parameters are homed into the shadow stack space, which Clang doesn't generally do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127915/new/

https://reviews.llvm.org/D127915



More information about the llvm-commits mailing list