[PATCH] D126114: [BOLT] Increase coverage of shrink wrapping [4/5]

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 20:01:00 PDT 2022


Amir accepted this revision.
Amir added a comment.
This revision is now accepted and ready to land.

To reiterate:

1. This diff changes the way save location is handled: instead of computing and keeping a single place for a given register, store the list of potential locations.
2. This is done in order to work around the issue when the single best location might be discarded down the stream, cancelling the move of a spill-fill for a given register.
3. In order to support iterating over save locations, computeDomOrder needs to be updated multiple times.

As a side effect of this change, we also fix an issue where the critical edge is split for a given reg placement, but the placement is canceled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126114/new/

https://reviews.llvm.org/D126114



More information about the llvm-commits mailing list