[PATCH] D127787: [TableGen][X86] Emit memory operand size table

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 19:58:43 PDT 2022


skan added inline comments.


================
Comment at: llvm/utils/TableGen/InstrInfoEmitter.cpp:468
+    SmallVector<StringRef> Matches;
+    if (!MemSizeRegex.match(Name, &Matches))
+      continue;
----------------
Could we add one field for class X86MemAsmOperand explicitly? I don't think regex is good way here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127787/new/

https://reviews.llvm.org/D127787



More information about the llvm-commits mailing list