[PATCH] D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 17:06:00 PDT 2022


nemanjai added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/LQ-STQ-32bit-offset.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mcpu=pwr8 -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
----------------
nemanjai wrote:
> What is this test case actually testing? It produces the same code with and without this patch.
Sorry, this isn't actually true. However with this patch, the frame index isn't actually removed during frame index elimination. So that doesn't test the intent of this test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126807/new/

https://reviews.llvm.org/D126807



More information about the llvm-commits mailing list