[PATCH] D127576: [RISCV] Teach vsetvli insertion to not insert redundant vsetvli right after VLEFF/VLSEGFF.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 07:50:41 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/required change.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/vsetvli-modify-vl.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64 -mattr=+v \
----------------
It's not clear to me what this test is covering that the one above doesn't.  It appears to be the same except for an extract vmseq?  You might consider dropping it entirely.

Either way, it shouldn't be it's own file.  Add to the end of vsetvli-insert.ll with a refined name please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127576/new/

https://reviews.llvm.org/D127576



More information about the llvm-commits mailing list