[PATCH] D119668: [lld-macho] Add -static

Tue Jun 14 05:39:16 PDT 2022

Link1J added inline comments.

================
Comment at: lld/test/MachO/static.s:2-4
+## If these tests start failing because `LC_SOURCE_VERSION` is added, please
+## update the `Load command` lines. Not emitting `LC_SOURCE_VERSION` to fix
+## this tests is the wrong behavior.
----------------
int3 wrote:
> can you elaborate here? Are you saying that `LC_SOURCE_VERSION` should really be emitted for both `-static` and regular links?
That is correct. But it doesn't appear to be implemented by `lld`. I don't know what `LC_SOURCE_VERSION` does, or if it is even useful. But by default `ld64` does emit `LC_SOURCE_VERSION` load command. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119668/new/

https://reviews.llvm.org/D119668