[PATCH] D119668: [lld-macho] Add -static

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 03:01:35 PDT 2022


int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/test/MachO/static.s:2-4
+## If these tests start failing because `LC_SOURCE_VERSION` is added, please
+## update the `Load command` lines. Not emitting `LC_SOURCE_VERSION` to fix
+## this tests is the wrong behavior.
----------------
can you elaborate here? Are you saying that `LC_SOURCE_VERSION` should really be emitted for both `-static` and regular links?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119668/new/

https://reviews.llvm.org/D119668



More information about the llvm-commits mailing list