[PATCH] D126523: [MachineSSAUpdater] compile time improvement in GetValueInMiddleOfBlock
Sameer Sahasrabuddhe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 14 01:29:10 PDT 2022
sameerds added a comment.
Same typo in the change description, last paragraph ... middle "of" the block.
================
Comment at: llvm/lib/CodeGen/MachineSSAUpdater.cpp:156-157
+ // Ok, we have already got a value for this block. If it is out of our block
+ // or it is a phi - we can re-use it as it will be defined in the middle block
+ // as well.
+ Register defR = getAvailableVals(AV).lookup(BB);
----------------
middle "of" the block?
================
Comment at: llvm/lib/Transforms/Utils/SSAUpdater.cpp:104
+ // Ok, we have already got a value for this block. If it is out of our block
+ // or it is a phi - we can re-use it as it will be defined in the middle block
+ // as well.
----------------
middle "of" the block?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126523/new/
https://reviews.llvm.org/D126523
More information about the llvm-commits
mailing list