[PATCH] D126523: [MachineSSAUpdater] compile time improvement in GetValueInMiddleOfBlock
    Sameer Sahasrabuddhe via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jun 14 01:27:48 PDT 2022
    
    
  
sameerds added a comment.
Looks straightforward enough to me. If the value is a PHI, it must be at the beginning of the current block. If it is outside this block, then whoever registered it is confident that it dominates this block. Is it correct that the SSAUpdater will not end up in a state where it tries to use a phi to produce another phi in the same block? Because that might race against the assumption that the used phi is available earlier in the block.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126523/new/
https://reviews.llvm.org/D126523
    
    
More information about the llvm-commits
mailing list