[llvm] 0d54a87 - Revert "[DWARF] Support 'G' in dwarf parser"

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 14:12:43 PDT 2022


Please include details about the reason for a revert/recommit in commit
messages to help reviewers/other readers understand what's being addressed
by these patches.

On Wed, Jun 8, 2022 at 1:53 PM Florian Mayer via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Florian Mayer
> Date: 2022-06-08T13:53:00-07:00
> New Revision: 0d54a874ee2449fdf081aeee07bc71e589f56251
>
> URL:
> https://github.com/llvm/llvm-project/commit/0d54a874ee2449fdf081aeee07bc71e589f56251
> DIFF:
> https://github.com/llvm/llvm-project/commit/0d54a874ee2449fdf081aeee07bc71e589f56251.diff
>
> LOG: Revert "[DWARF] Support 'G' in dwarf parser"
>
> This reverts commit 4c71c3386c5c79560517a22e75938c9951f8de68.
>
> Added:
>
>
> Modified:
>     llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
>
> Removed:
>     llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
> b/llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
> index 9e5cbc601546..86b4a2fe270f 100644
> --- a/llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
> +++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
> @@ -1138,10 +1138,6 @@ Error DWARFDebugFrame::parse(DWARFDataExtractor
> Data) {
>              // B-Key is used for signing functions associated with this
>              // augmentation string
>              break;
> -            // This stack frame contains MTE tagged data, so needs to be
> -            // untagged on unwind.
> -          case 'G':
> -            break;
>            }
>          }
>
>
> diff  --git a/llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
> b/llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
> deleted file mode 100644
> index a5e9c24261bc..000000000000
> --- a/llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -# RUN: llvm-mc -filetype=obj -triple aarch64 -mattr=+mte %s -o %t.o
> -# RUN: llvm-dwarfdump --eh-frame %t.o | FileCheck %s
> -
> -# CHECK: Augmentation:          "zRG"
> -
> -       .text
> -       .globl  WithUnwind
> -       .p2align        2
> -       .type   WithUnwind, at function
> -WithUnwind:
> -       .cfi_startproc
> -       .cfi_mte_tagged_frame
> -       ret
> -.Lfunc_end0:
> -       .size   WithUnwind, .Lfunc_end0-WithUnwind
> -       .cfi_endproc
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220613/aa6b3116/attachment.html>


More information about the llvm-commits mailing list