[PATCH] D127508: [SelectionDAG] Extend WidenVecOp_INSERT_SUBVECTOR to cover more cases.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5798
       N->getConstantOperandVal(2) == 0)
-    return SubVec;
+    return DAG.getNode(ISD::INSERT_SUBVECTOR, SDLoc(N), VT, InVec, SubVec,
+                       N->getOperand(2));
----------------
sdesmalen wrote:
> Given that no other tests have changed, I assume that `getNode` returns `SubVec` if `SubVec.getValueType() == InVec.getValueType()` ?
Yes, after the asserts to ensure the insert is valid it starts with
```
    // Trivial insertion.
    if (VT == N2VT)
      return N2;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127508/new/

https://reviews.llvm.org/D127508