[PATCH] D127508: [SelectionDAG] Extend WidenVecOp_INSERT_SUBVECTOR to cover more cases.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 10:39:30 PDT 2022


sdesmalen accepted this revision.
sdesmalen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5798
       N->getConstantOperandVal(2) == 0)
-    return SubVec;
+    return DAG.getNode(ISD::INSERT_SUBVECTOR, SDLoc(N), VT, InVec, SubVec,
+                       N->getOperand(2));
----------------
Given that no other tests have changed, I assume that `getNode` returns `SubVec` if `SubVec.getValueType() == InVec.getValueType()` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127508/new/

https://reviews.llvm.org/D127508



More information about the llvm-commits mailing list