[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/shuffle-tbl34.ll:572
+; CHECK-NEXT:    mov v4.b[7], v1.b[12]
+; CHECK-NEXT:    fmov d0, d4
 ; CHECK-NEXT:    ret
----------------
This win is negated by D127595


================
Comment at: llvm/test/CodeGen/X86/buildvec-insertvec.ll:80
 
-; FIXME: This could be 'movhpd {{.*#+}} xmm0 = xmm0[0],mem[0]'.
-
 define <2 x double> @test_negative_zero_2(<2 x double> %A) {
+; SSE-LABEL: test_negative_zero_2:
----------------
This improvement is negated by D127595


================
Comment at: llvm/test/CodeGen/X86/horizontal-sum.ll:1073
+; SSSE3-FAST-NEXT:    phaddd %xmm2, %xmm3
+; SSSE3-FAST-NEXT:    shufps {{.*#+}} xmm0 = xmm0[0,2],xmm3[2,0]
 ; SSSE3-FAST-NEXT:    retq
----------------
This was a win that gets reverted by D127595


================
Comment at: llvm/test/CodeGen/X86/sse41.ll:1166
+; X86-SSE-NEXT:    ## fixup A - offset: 5, value: {{\.?LCPI[0-9]+_[0-9]+}}, kind: FK_Data_4
+; X86-SSE-NEXT:    retl ## encoding: [0xc3]
 ;
----------------
D127595 reverts this optimization :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115