[PATCH] D127562: [lld-macho] Add support for exporting no symbols

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 12 10:26:41 PDT 2022


thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1409
+  bool emptyExportedSymbolsList =
+      args.hasArg(OPT_exported_symbols_list) && config->exportedSymbols.empty();
+  bool exportNoSymbols =
----------------
(very nit: I find this name a bit hard to read, since `empty` is also a verb and this reads like "should I empty the exported symbols list" to me)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127562/new/

https://reviews.llvm.org/D127562



More information about the llvm-commits mailing list