[PATCH] D127205: [LoongArch] Use register R0 (ZERO) for constant 0

Fri Jun 10 20:59:21 PDT 2022

SixWeining added a comment.

In D127205#3575174 <https://reviews.llvm.org/D127205#3575174>, @MaskRay wrote:

> In D127205#3575164 <https://reviews.llvm.org/D127205#3575164>, @SixWeining wrote:
>
>> In D127205#3575143 <https://reviews.llvm.org/D127205#3575143>, @MaskRay wrote:
>>
>>>> Depends on D127204 <https://reviews.llvm.org/D127204>
>>>
>>> The dependency is inverted.
>>>
>>> I think this should be placed before other patches.
>>
>> The reason why I place it after other patches is that we can obviously see the improvements from the test (introduced by early patches) updates. If this is not good, I can revert the dependency. There is no problem. Thanks.
>
> If you think it's worthwhile, you can mention this in D127204 <https://reviews.llvm.org/D127204>'s summary. No need to add unnecessary intermediate steps to the tests to show the effect.

That sounds good. Let me mention this in D127204 <https://reviews.llvm.org/D127204>'s summary. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127205/new/

https://reviews.llvm.org/D127205