[PATCH] D127205: [LoongArch] Use register R0 (ZERO) for constant 0

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 20:54:25 PDT 2022


MaskRay added a comment.

In D127205#3575164 <https://reviews.llvm.org/D127205#3575164>, @SixWeining wrote:

> In D127205#3575143 <https://reviews.llvm.org/D127205#3575143>, @MaskRay wrote:
>
>>> Depends on D127204 <https://reviews.llvm.org/D127204>
>>
>> The dependency is inverted.
>>
>> I think this should be placed before other patches.
>
> The reason why I place it after other patches is that we can obviously see the improvements from the test (introduced by early patches) updates. If this is not good, I can revert the dependency. There is no problem. Thanks.

If you think it's worthwhile, you can mention this in D127204 <https://reviews.llvm.org/D127204>'s summary. No need to add unnecessary intermediate steps to the tests to show the effect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127205/new/

https://reviews.llvm.org/D127205



More information about the llvm-commits mailing list