[PATCH] D127549: RISCV: handle 64-bit PCREL data relocations

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 18:07:02 PDT 2022


compnerd added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:236
+    // Avoid relaxation for symbolic difference in debug and eh_frame sections
+    if (A.isInSection())
+      return !IsDebugOrEHFrameSection(A.getSection());
----------------
craig.topper wrote:
> Should relaxation here be relocation?
In the case of a compact code model, we can relax the pair of relocations to a single relocation.  You would still have a relocation, it just is a nominally smaller file, and fewer relocations for the linker to process.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127549/new/

https://reviews.llvm.org/D127549



More information about the llvm-commits mailing list