[PATCH] D127507: AMDGPU: Use isMeta flags on pseudoinstructions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:1768
   default:
     if (MI.isMetaInstruction())
       return 0;
----------------
foad wrote:
> Could we check isPseudo here instead of marking all our pseudos with isMeta? Or does isPseudo mean something different from what we mean by a pseudo instruction?
isPseudo is different. Basically all of our instructions are isPseudo because they are the "generic" versions of instructions which get converted to the real opcodes at emission time


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127507/new/

https://reviews.llvm.org/D127507