[PATCH] D127507: AMDGPU: Use isMeta flags on pseudoinstructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 09:32:54 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:1768
   default:
     if (MI.isMetaInstruction())
       return 0;
----------------
Could we check isPseudo here instead of marking all our pseudos with isMeta? Or does isPseudo mean something different from what we mean by a pseudo instruction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127507/new/

https://reviews.llvm.org/D127507



More information about the llvm-commits mailing list