[PATCH] D126361: [DebugInfo][ARM] Not readonly check for RWPI globals

Amilendra Kodithuwakku via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 02:38:59 PDT 2022


amilendra added inline comments.


================
Comment at: llvm/test/DebugInfo/ARM/ropi.ll:21
+!1 = distinct !DIGlobalVariable(name: "global", scope: !2, file: !5, line: 1, type: !6, isLocal: false, isDefinition: true)
+!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "clang version 15.0.0 (https://github.com/llvm/llvm-project.git 3948962b454022c2c8de6f67942a9cbd1f0351a0)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, globals: !4, splitDebugInlining: false, nameTableKind: None)
+!3 = !DIFile(filename: "/tmp/ropi.c", directory: "/tmp")
----------------
amilendra wrote:
> I think these version specific content are not needed, and could break after the next version is branched?
Ah wait. These are fixed information so no specific to the commit or environment. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126361/new/

https://reviews.llvm.org/D126361



More information about the llvm-commits mailing list