[PATCH] D126361: [DebugInfo][ARM] Not readonly check for RWPI globals

[Amilendra Kodithuwakku via Phabricator via llvm-commits]

amilendra added inline comments.


================
Comment at: llvm/test/DebugInfo/ARM/ropi.ll:21
+!1 = distinct !DIGlobalVariable(name: "global", scope: !2, file: !5, line: 1, type: !6, isLocal: false, isDefinition: true)
+!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "clang version 15.0.0 (https://github.com/llvm/llvm-project.git 3948962b454022c2c8de6f67942a9cbd1f0351a0)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, globals: !4, splitDebugInlining: false, nameTableKind: None)
+!3 = !DIFile(filename: "/tmp/ropi.c", directory: "/tmp")
----------------
I think these version specific content are not needed, and could break after the next version is branched?


================
Comment at: llvm/test/DebugInfo/ARM/ropi.ll:22
+!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "clang version 15.0.0 (https://github.com/llvm/llvm-project.git 3948962b454022c2c8de6f67942a9cbd1f0351a0)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, globals: !4, splitDebugInlining: false, nameTableKind: None)
+!3 = !DIFile(filename: "/tmp/ropi.c", directory: "/tmp")
+!4 = !{!0}
----------------
Environment specific content; could potentially fail on Windows?



================
Comment at: llvm/test/DebugInfo/ARM/ropi.ll:34
+!14 = !{i32 8, !"sign-return-address-all", i32 0}
+!15 = !{i32 8, !"sign-return-address-with-bkey", i32 0}
+!16 = !{i32 7, !"frame-pointer", i32 2}
----------------
Do we need to check for these?
I think this test case can be considerably reduced to use only the bare minimum needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126361/new/

https://reviews.llvm.org/D126361