[PATCH] D126989: [AMDGPU] gfx11 VOPC instructions

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added a comment.

MC layer changes look good to me, thanks!



================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:629
+bool AMDGPUInstPrinter::needsImpliedVcc(const MCInstrDesc &Desc,
+                                     unsigned OpNo) const {
+  return OpNo == 1 && (Desc.TSFlags & SIInstrFlags::DPP) &&
----------------
Indent


================
Comment at: llvm/lib/Target/AMDGPU/VOPCInstructions.td:1030
+
+  let Inst{39-32} = !if (P.HasSrc0, src0{7 - 0}, 0);
+  let Inst{48-40} = dpp_ctrl;
----------------
There are 9 more lines where bit range is specified with spaces around "-".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126989/new/

https://reviews.llvm.org/D126989