[PATCH] D126989: [AMDGPU] gfx11 VOPC instructions

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 11:04:23 PDT 2022


Joe_Nash marked an inline comment as done.
Joe_Nash added a comment.

Addressed all comments. PTAL



================
Comment at: llvm/test/MC/AMDGPU/gfx11_asm_vopc_dpp.s:121
+; dpp
+; ================================================================
+
----------------
dp wrote:
> IMO the tests would look cleaner with uniform comments token ('//') and uniform (3-line) separator.
I have changed to a uniform ('//') comment token. The separators are hierarchical, so I would prefer to leave them heterogeneous.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126989/new/

https://reviews.llvm.org/D126989



More information about the llvm-commits mailing list