[PATCH] D126800: Write output sections in parallel

[Michael Eisel via Phabricator via llvm-commits]

michaeleisel added a comment.

@thakis any action items for me? It sounds like you're going to do the append_range change. Also, we can remove the `#include` I added, since it looks like it's already present further down. And lastly, I tested with the following patch as you specified and tests pass:

  diff --git a/lld/test/MachO/invalid/range-check.s b/lld/test/MachO/invalid/range-check.s
  index 2f087e38c266..1ad719cfa31d 100644
  --- a/lld/test/MachO/invalid/range-check.s
  +++ b/lld/test/MachO/invalid/range-check.s
  @@ -6,11 +6,11 @@
   # RUN: %lld -dylib %t/bar.o -o %t/libbar.dylib
   # RUN: not %lld -lSystem -o /dev/null %t/libbar.dylib %t/test.o 2>&1 | FileCheck %s
   
  -# CHECK: error: {{.*}}test.o:(symbol _main+0xd): relocation UNSIGNED is out of range: [[#]] is not in [0, 4294967295]; references _foo
  -# CHECK: error: {{.*}}test.o:(symbol _main+0x3): relocation GOT_LOAD is out of range: [[#]] is not in [-2147483648, 2147483647]; references _foo
  -# CHECK: error: stub is out of range: [[#]] is not in [-2147483648, 2147483647]; references _bar
  -# CHECK: error: stub helper header is out of range: [[#]] is not in [-2147483648, 2147483647]
  -# CHECK: error: stub helper header is out of range: [[#]] is not in [-2147483648, 2147483647]
  +# CHECK-DAG: error: {{.*}}test.o:(symbol _main+0xd): relocation UNSIGNED is out of range: [[#]] is not in [0, 4294967295]; references _foo
  +# CHECK-DAG: error: {{.*}}test.o:(symbol _main+0x3): relocation GOT_LOAD is out of range: [[#]] is not in [-2147483648, 2147483647]; references _foo
  +# CHECK-DAG: error: stub is out of range: [[#]] is not in [-2147483648, 2147483647]; references _bar
  +# CHECK-DAG: error: stub helper header is out of range: [[#]] is not in [-2147483648, 2147483647]
  +# CHECK-DAG: error: stub helper header is out of range: [[#]] is not in [-2147483648, 2147483647]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126800/new/

https://reviews.llvm.org/D126800