[PATCH] D126800: Write output sections in parallel

Wed Jun 8 11:17:06 PDT 2022

thakis added a comment.

In D126800#3567537 <https://reviews.llvm.org/D126800#3567537>, @oontvoo wrote:

> In D126800#3567521 <https://reviews.llvm.org/D126800#3567521>, @thakis wrote:
>
>> I think I changed my mind here. If Jez think it's fine, I suppose it's fine to have non-successful links have non-deterministic diags. So maybe just -DAG'ing the test is fine.
>>
>> And if we decide it's not fine, then we should make the diag output deterministic again in a follow-up and not as part of this change. So relanding with tweaked test LGTM, actually.
>
> Worth noting this is not the only place where we have non-deterministic ordering of diag messages.  There's one here <https://github.com/llvm/llvm-project/blob/835fcf2aa5127bf99a1e6397c72153f00a0497b2/lld/MachO/Driver.cpp#L1569> too (which you'd requested changing but I hadn't got to yet :) )

This one's kind of worse as it's a warning imho -- so here we have nondeterministic output on a _successful_ link.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126800/new/

https://reviews.llvm.org/D126800