[PATCH] D124926: [LoopInterchange] New cost model for loop interchange

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/LoopCacheAnalysis.cpp:51-52
+    "default-cache-line-size", cl::init(64), cl::Hidden,
+    cl::desc("Use this to specify a cache line size if not provided by the "
+             "backend TargetTransformInfo"));
+
----------------
bmahjour wrote:
> 
The name and description seems to imply this specifies the cache-line size in general, but here it only applies to the use in CacheCost. Should the setting be directly be applied in `TTI::getCacheLineSize`?

Also, the change to add the option should probably be landed separately, with a test in `llvm/test/Analysis/LoopCacheAnalsysis`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124926/new/

https://reviews.llvm.org/D124926